Ticket #14306: translations_cleanup.diff

django/utils/translation/__init__.py

@@ -20 +20 @@
 # replace the functions with their real counterparts (once we do access the
 # settings).
 
-def delayed_loader(real_name, *args, **kwargs):
+class TransProvider(object):
     """
-    Call the real, underlying function.  We have a level of indirection here so
-    that modules can use the translation bits without actually requiring
-    Django's settings bits to be configured before import.
+    The purpose of this class is to store the actual translation function upon
+    receiving the first call to that function. After this is done, changes to
+    USE_I18N will have no effect to which function is served upon request. If
+    your tests rely on changing USE_I18N, you can delete all the functions
+    from _trans_provider.__dict__.
+    
+    Note that storing the function with setattr will have a noticeable
+    performance effect, as access to the function goes the normal path,
+    instead of using __getattr__.
     """
-    from django.conf import settings
-    if settings.USE_I18N:
-        from django.utils.translation import trans_real as trans
-    else:
-        from django.utils.translation import trans_null as trans
+    def __getattr__(self, name):
+        from django.conf import settings
+        if settings.USE_I18N:
+            from django.utils.translation import trans_real as trans_provider
+        else:
+            from django.utils.translation import trans_null as trans_provider
+        setattr(self, name, getattr(trans_provider, name))
+        return getattr(trans_provider, name)
 
-    # Make the originally requested function call on the way out the door.
-    return getattr(trans, real_name)(*args, **kwargs)
+_trans_provider = TransProvider()
 
-g = globals()
-for name in __all__:
-    g['real_%s' % name] = curry(delayed_loader, name)
-del g, delayed_loader
+# The TransProvider class is no more needed, so remove it from the namespace.
+del TransProvider
 
 def gettext_noop(message):
-    return real_gettext_noop(message)
+    global _trans_provider
+    return _trans_provider.gettext_noop(message)
 
 ugettext_noop = gettext_noop
 
 def gettext(message):
-    return real_gettext(message)
+    global _trans_provider
+    return _trans_provider.gettext(message)
 
 def ngettext(singular, plural, number):
-    return real_ngettext(singular, plural, number)
+    global _trans_provider
+    return _trans_provider.ngettext(singular, plural, number)
 
 def ugettext(message):
-    return real_ugettext(message)
+    global _trans_provider
+    return _trans_provider.ugettext(message)
 
 def ungettext(singular, plural, number):
-    return real_ungettext(singular, plural, number)
+    global _trans_provider
+    return _trans_provider.ungettext(singular, plural, number)
 
 ngettext_lazy = lazy(ngettext, str)
 gettext_lazy = lazy(gettext, str)
@@ -63 +74 @@
 ugettext_lazy = lazy(ugettext, unicode)
 
 def activate(language):
-    return real_activate(language)
+    global _trans_provider
+    return _trans_provider.activate(language)
 
 def deactivate():
-    return real_deactivate()
+    global _trans_provider
+    return _trans_provider.deactivate()
 
 def get_language():
-    return real_get_language()
+    global _trans_provider
+    return _trans_provider.get_language()
 
 def get_language_bidi():
-    return real_get_language_bidi()
+    global _trans_provider
+    return _trans_provider.get_language_bidi()
 
 def get_date_formats():
-    return real_get_date_formats()
+    global _trans_provider
+    return _trans_provider.get_date_formats()
 
 def get_partial_date_formats():
-    return real_get_partial_date_formats()
+    global _trans_provider
+    return _trans_provider.get_partial_date_formats()
 
 def check_for_language(lang_code):
-    return real_check_for_language(lang_code)
+    global _trans_provider
+    return _trans_provider.check_for_language(lang_code)
 
 def to_locale(language):
-    return real_to_locale(language)
+    global _trans_provider
+    return _trans_provider.to_locale(language)
 
 def get_language_from_request(request):
-    return real_get_language_from_request(request)
+    global _trans_provider
+    return _trans_provider.get_language_from_request(request)
 
 def templatize(src):
-    return real_templatize(src)
+    global _trans_provider
+    return _trans_provider.templatize(src)
 
 def deactivate_all():
-    return real_deactivate_all()
+    global _trans_provider
+    return _trans_provider.deactivate_all()
 
 def _string_concat(*strings):
     """

django/utils/translation/trans_real.py

@@ -80 +80 @@
 
     def set_language(self, language):
         self.__language = language
+        self.__to_language = to_language(language)
 
     def language(self):
         return self.__language
+    
+    def to_language(self):
+        return self.__to_language
 
     def __repr__(self):
         return "<DjangoTranslation lang:%s>" % self.__language
@@ -214 +218 @@
     t = _active.get(currentThread(), None)
     if t is not None:
         try:
-            return to_language(t.language())
+            return t.to_language()
         except AttributeError:
             pass
     # If we don't have a real translation object, assume it's the default language.