Ticket #12295: empty-formset-is-not-valid-with-unittests.diff

django/forms/formsets.py

@@ -254 +254 @@
         # We loop over every form.errors here rather than short circuiting on the
         # first failure to make sure validation gets triggered for every form.
         forms_valid = True
+        err = self.errors
         for i in range(0, self.total_form_count()):
             form = self.forms[i]
             if self.can_delete:

tests/regressiontests/forms/formsets.py

@@ -1 +1 @@
 # -*- coding: utf-8 -*-
+from django.test.testcases import TestCase
 tests = """
 # Basic FormSet creation and usage ############################################
 
@@ -722 +723 @@
 <ul class="errorlist"><li>You may only specify a drink once.</li></ul>
 
 """
+
+from django import forms
+from django.forms.formsets import BaseFormSet, formset_factory
+
+class EmptyFsetWontValidate(BaseFormSet):
+    def clean(self):
+        raise forms.ValidationError, "Clean method called"
+
+class SimpleForm(forms.Form):
+    name = forms.CharField()
+
+
+class TestEmptyFormSet(TestCase):
+    def test_empty_formset_is_valid(self):
+        EmptyFsetWontValidateFormset = formset_factory(SimpleForm, extra=0, formset=EmptyFsetWontValidate)
+        formset = EmptyFsetWontValidateFormset(data={'form-INITIAL_FORMS':'0', 'form-TOTAL_FORMS':'0'},prefix="form")
+        formset2 = EmptyFsetWontValidateFormset(data={'form-INITIAL_FORMS':'0', 'form-TOTAL_FORMS':'1', 'form-0-name':'bah' },prefix="form")
+        
+        self.assertFalse(formset.is_valid())
+        self.assertFalse(formset2.is_valid())

tests/regressiontests/forms/tests.py

@@ -40 +40 @@
 from fields import FieldsTests
 from validators import TestFieldWithValidators
 from widgets import WidgetTests
+from formsets import TestEmptyFormSet
 
 from input_formats import *